Skip to content

fix(LeftSidebar): wrong user status after scrolling #10356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Antreesy merged 1 commit into from
Aug 25, 2023
Merged

fix(LeftSidebar): wrong user status after scrolling #10356

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/components/ConversationIcon.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,11 @@
:height="size"
:alt="item.displayName"
class="avatar icon">
<!-- NcAvatar doesn't fully support props update and works only for 1 user -->
<!-- Using key on NcAvatar forces NcAvatar re-mount and solve the problem, could not really optimal -->
<!-- TODO: Check if props update support in NcAvatar is more performant -->
<NcAvatar v-else
:key="item.token"
:size="size"
:user="item.name"
:disable-menu="disableMenu"
Expand All @@ -48,14 +52,12 @@
class="conversation-icon__avatar" />
<div v-if="showCall"
class="overlap-icon">
<VideoIcon :size="20"
:fill-color="'#E9322D'" />
<VideoIcon :size="20" :fill-color="'#E9322D'" />
<span class="hidden-visually">{{ t('spreed', 'Call in progress') }}</span>
</div>
<div v-else-if="showFavorite"
class="overlap-icon">
<Star :size="20"
:fill-color="'#FFCC00'" />
<Star :size="20" :fill-color="'#FFCC00'" />
<span class="hidden-visually">{{ t('spreed', 'Favorite') }}</span>
</div>
</div>
Expand Down