Call connections sometimes fail to be established when using the internal signaling server and PostgreSQL

[danxuliu]

How to use GitHub

• Please use the 👍 reaction to show that you are affected by the same issue.
• Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
• Subscribe to receive notifications on status change and new comments.

---

When the internal signaling server is used the signaling messages are stored in the database when sent, and then read from the database when fetched by the target participant. In order to establish a call connection some signaling messages must be received in the same order that they were sent (the remote description must be processed before processing the remote candidates); otherwise the connection can not be established. However, when using PostgreSQL the input and output order can be different, and when that happens the signaling messages are received in the wrong order, thus causing the connection to not be established.

[nickvergessen]

Should be rather easy. We can sort by the autoincrement in

spreed/lib/Signaling/Messages.php

Lines 128 to 132 in c07251f

	$query = $this->db->getQueryBuilder();
	$query->select('*')
	->from('talk_internalsignaling')
	->where($query->expr()->eq('recipient', $query->createNamedParameter($sessionId)))
	->andWhere($query->expr()->lte('timestamp', $query->createNamedParameter($time)));

or sort the array by the id before returning.