Skip to content

Fix Chart.js Syntax #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
blizzz merged 1 commit into from Jun 16, 2021
Merged

Fix Chart.js Syntax #319

blizzz merged 1 commit into from Jun 16, 2021

Conversation

@ghost
Copy link

@ghost ghost commented Jun 13, 2021

Before

Before

After

After

Fix Chart.js Syntax
6ca2eba 
Signed-off-by: HouraisanNEET <[email protected]>
@szaimen szaimen added this to the Nextcloud 22 milestone Jun 13, 2021
@blizzz blizzz mentioned this pull request Jun 16, 2021
Merged
45 tasks
@blizzz
Copy link
Member

blizzz commented Jun 16, 2021

Is yAxes even still correct or should not be it just y?

@ghost
Copy link
Author

ghost commented Jun 16, 2021

Both yAxes and y are valid. And I keep yAxes for now.

blizzz
blizzz approved these changes Jun 16, 2021
View reviewed changes
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

@blizzz blizzz merged commit b014ba8 into nextcloud:master Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

3. to review

Projects

None yet

Milestone

Nextcloud 22

Development

Successfully merging this pull request may close these issues.

2 participants

@blizzz @szaimen