feat(sharing): Make share permission in bundled edit configurable #57741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfebe
requested review from
artonge,
marcoambrosini,
provokateurin and
susnux
nfebe
requested review from
come-nc and
sorbaugh
and removed request for
a team
nfebe
force-pushed
the
feat/configurable-share-permission-in-bundled
branch
2 times, most recently
from
8f0083f to
2c1ee9c
Compare
Member
|
/backport to stable33 |
come-nc
requested changes
Jan 26, 2026
Contributor
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
The setting shoud be in the application files_sharing, not in core.
nfebe
force-pushed
the
feat/configurable-share-permission-in-bundled
branch
from
2c1ee9c to
2ace2b6
Compare
nfebe
changed the title
nfebe
force-pushed
the
feat/configurable-share-permission-in-bundled
branch
2 times, most recently
from
bd1649c to
274dbb8
Compare
nfebe
force-pushed
the
feat/configurable-share-permission-in-bundled
branch
3 times, most recently
from
949deb5 to
262cf8c
Compare
come-nc
reviewed
Jan 29, 2026
Contributor
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
You pushed 3rdparty by mistake.
Also, is it expected that the new option is false by default? I thought the previous behaviour was to include it?
nfebe
force-pushed
the
feat/configurable-share-permission-in-bundled
branch
3 times, most recently
from
fd9f04b to
617c31f
Compare
provokateurin
requested changes
Jan 29, 2026
come-nc
requested changes
Jan 29, 2026
nfebe
force-pushed
the
feat/configurable-share-permission-in-bundled
branch
2 times, most recently
from
7e9ef21 to
3ed65a8
Compare
provokateurin
requested changes
Jan 29, 2026
Member
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
LGTM, just one small change please.
nfebe
force-pushed
the
feat/configurable-share-permission-in-bundled
branch
2 times, most recently
from
d1e35e9 to
79e1214
Compare
Add config option shareapi_bundle_reshare_with_edit to include reshare permission in "Allow editing" bundle. Default is true to maintain backward compatibility. Signed-off-by: nfebe <[email protected]>
nfebe
force-pushed
the
feat/configurable-share-permission-in-bundled
branch
from
79e1214 to
f729f27
Compare
provokateurin
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add config option
shareapi_include_share_in_editto include reshare permission in "Allow editing" bundle.