Skip to content

Conversation

@SebastianKrupinski
Copy link
Contributor

@SebastianKrupinski SebastianKrupinski commented Dec 8, 2025

Summary

Checklist

@SebastianKrupinski
Copy link
Contributor Author

@ChristophWurst @kesselb @DerDreschner review please

@nextcloud-bot nextcloud-bot mentioned this pull request Jan 14, 2026
@DerDreschner DerDreschner requested a review from kesselb January 15, 2026 15:41
@SebastianKrupinski
Copy link
Contributor Author

@ChristophWurst @kesselb @hamza221 review please

@SebastianKrupinski SebastianKrupinski force-pushed the feat/tentative-invitations branch from f434863 to 0da2066 Compare January 15, 2026 16:33
Copy link
Contributor

@kesselb kesselb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Array shape needs an update; otherwise it won't match what's implemented in nextcloud/mail#12144.

* Handles a iMip message
*
* @param array{absent?: "create", recipient?: string} $options
* @param array{absent?: "create", absentCreateStatus?: string, recipient?: string} $options
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @param array{absent?: "create", absentCreateStatus?: string, recipient?: string} $options
* @param array{absent?: "create"|"ignore", absentCreateStatus?: "cancelled"|"confirmed"|"tentative", recipient?: string, ...} $options

... tell Psalm to be a bit more relaxed about additional fields in the future ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Done

Signed-off-by: SebastianKrupinski <[email protected]>
@SebastianKrupinski SebastianKrupinski merged commit 4c6981b into master Jan 15, 2026
232 of 239 checks passed
@SebastianKrupinski SebastianKrupinski deleted the feat/tentative-invitations branch January 15, 2026 20:01
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 💌 📅 👥 Groupware team Jan 15, 2026
@ChristophWurst ChristophWurst added the pending documentation This pull request needs an associated documentation update label Jan 16, 2026
@ChristophWurst
Copy link
Member

Documentation (manuals or wiki) has been updated or is not required

@SebastianKrupinski that checkbox is already ticket while there is no developer documentation for the public API change as far as I can see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement pending documentation This pull request needs an associated documentation update

Projects

Status: ☑️ Done

Development

Successfully merging this pull request may close these issues.

Add invites to calendar automatically (tentative without respond)

5 participants