refactor(files_trashbin): migrate app to Vue 3 #56439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
feature: vue apps
♻️ refactor
susnux
requested review from
CarlSchwan,
nfebe,
provokateurin and
sorbaugh
and removed request for
a team
32 tasks
CarlSchwan
approved these changes
Nov 14, 2025
artonge
approved these changes
Nov 14, 2025
| import type { FileStat, ResponseDataDetailed } from 'webdav' | ||
|
|
||
| import { davResultToNode, getDavNameSpaces, getDavProperties } from '@nextcloud/files' | ||
| import { resultToNode as davResultToNode, getDavNameSpaces, getDavProperties } from '@nextcloud/files/dav' |
Contributor
There was a problem hiding this comment.
Why not keep the original name?
Contributor
Author
There was a problem hiding this comment.
Because we already use that name below
Contributor
Author
There was a problem hiding this comment.
(we wrap it and export the wrapping function using that name)
susnux
force-pushed
the
refactor/files_trashbin-vue3
branch
from
0f7ab2b to
945bd4f
Compare
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
refactor/files_trashbin-vue3
branch
from
945bd4f to
5daeee2
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated app to Vue 3 and fixed some cross dependencies between apps that are still Vue 2.
Also fixed some Typescript issues.
Checklist
3. to review, feature component)stable32)