Skip to content

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Nov 13, 2025

Found 1 abandoned package:
+-------------------+----------------------------------------------------------------------------------+
| Abandoned Package | Suggested Replacement                                                            |
+-------------------+----------------------------------------------------------------------------------+
| icewind/smb       | none                                                                             |
+-------------------+----------------------------------------------------------------------------------+
Prod Packages Operation Base Target
icewind/smb Upgraded v3.7.0 v3.8.1

@nickvergessen nickvergessen added this to the Nextcloud 33 milestone Nov 13, 2025
@nickvergessen nickvergessen self-assigned this Nov 13, 2025
@nickvergessen nickvergessen requested a review from a team as a code owner November 13, 2025 12:59
@nickvergessen nickvergessen requested review from Altahrim, icewind1991 and provokateurin and removed request for a team November 13, 2025 12:59
@nickvergessen
Copy link
Member Author

Error: apps/files_external/lib/Lib/Storage/SystemBridge.php:17:28: InvalidExtendClass: Class OCA\Files_External\Lib\Storage\SystemBridge may not inherit from final class Icewind\SMB\System (see https://psalm.dev/232)
Error: apps/files_external/lib/Lib/Storage/SystemBridge.php:23:2: MethodSignatureMismatch: Method Icewind\SMB\System::getBinaryPath is declared final and cannot be overridden (see https://psalm.dev/042)

@icewind1991 can you assist us as a maintainer here?

@icewind1991
Copy link
Member

published 3.8.1 which should fix this

@nickvergessen
Copy link
Member Author

Thanks, updated to that and repushing

@nickvergessen nickvergessen force-pushed the build/noid/update-icewind-smb branch from 156eec8 to 0f8100d Compare November 14, 2025 08:05
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen nickvergessen force-pushed the build/noid/update-icewind-smb branch from 0f8100d to c58b8cc Compare November 14, 2025 10:33
@nickvergessen nickvergessen merged commit f2f9cb7 into master Nov 14, 2025
227 of 245 checks passed
@nickvergessen nickvergessen deleted the build/noid/update-icewind-smb branch November 14, 2025 15:38
@nextcloud-bot nextcloud-bot mentioned this pull request Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants