-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
fix(l10n): Nicer capitalization for generic messages #56283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Follow-up to #54202 Actually seeing these in production made me realize that they look awkward without a capital letter at the start. Signed-off-by: kramo <[email protected]>
|
Hello @kra-mo , We currently have a colorful mix on this topic in our strings. Are your changes based on a known specification? https://commission.europa.eu/document/download/c45f5b70-2d0e-4da7-b181-b5fe3a16c4bb_en says in chapter 2.7 (page 13): Same here: Do you know of any specifications that we could use in our guidelines? |
rakekniven
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment.
Let us define a rule before applying such changes.
|
My only thought was that since the string before it is inserted dynamically and is in a different mood, it could never form a complete sentence with what is after it so it just felt very weird to not break it up more. I don't think capitalization after colons should be a rule in general, this is just a one-off because of the weird way this sting is constructed. But I'd love to get rid of these strings and replace them with more natural ones in the future. |
Follow-up to #54202
Summary
Actually seeing these in production made me realize that they look awkward without a capital letter at the start.
Checklist
3. to review, feature component)