Skip to content

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Nov 7, 2025

Fix #55660
Regression from #55073

Sometimes the value is null

@skjnldsv skjnldsv added this to the Nextcloud 33 milestone Nov 7, 2025
@skjnldsv skjnldsv self-assigned this Nov 7, 2025
@skjnldsv skjnldsv requested a review from a team as a code owner November 7, 2025 07:51
@skjnldsv skjnldsv requested review from nfebe, sorbaugh and szaimen and removed request for a team November 7, 2025 07:51
@skjnldsv
Copy link
Member Author

skjnldsv commented Nov 7, 2025

/backport d116c38 to stable32

@skjnldsv
Copy link
Member Author

skjnldsv commented Nov 7, 2025

/backport d116c38 to stable31

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes the value is null

😱

@skjnldsv
Copy link
Member Author

/compile rebase

@nextcloud-command nextcloud-command force-pushed the fix/sharing-password-checkbow branch from d116c38 to 8d8f5f4 Compare November 18, 2025 05:01
@skjnldsv skjnldsv merged commit 754ef25 into master Nov 18, 2025
108 checks passed
@skjnldsv skjnldsv deleted the fix/sharing-password-checkbow branch November 18, 2025 05:05
@backportbot
Copy link

backportbot bot commented Nov 18, 2025

The backport to stable31 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable31
git pull origin stable31

# Create the new backport branch
git checkout -b backport/56278/stable31

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick d116c38

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/56278/stable31

Error: Failed to check for changes with origin/stable31: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot
Copy link

backportbot bot commented Nov 18, 2025

The backport to stable32 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable32
git pull origin stable32

# Create the new backport branch
git checkout -b backport/56278/stable32

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick d116c38

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/56278/stable32

Error: Failed to check for changes with origin/stable32: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@skjnldsv
Copy link
Member Author

/backport d32878e to stable32

@skjnldsv
Copy link
Member Author

/backport d32878e to stable31

@backportbot
Copy link

backportbot bot commented Nov 18, 2025

The backport to stable32 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable32
git pull origin stable32

# Create the new backport branch
git checkout -b backport/56278/stable32

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick d32878e6

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/56278/stable32

Error: Failed to check for changes with origin/stable32: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot
Copy link

backportbot bot commented Nov 18, 2025

The backport to stable31 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable31
git pull origin stable31

# Create the new backport branch
git checkout -b backport/56278/stable31

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick d32878e6

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/56278/stable31

Error: Failed to check for changes with origin/stable31: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@oleksandr-nc oleksandr-nc restored the fix/sharing-password-checkbow branch November 18, 2025 13:05
@oleksandr-nc
Copy link
Contributor

@skjnldsv should we ask dependebot again to do backports? (after restoring branch)

@elzody
Copy link
Contributor

elzody commented Dec 1, 2025

/backport to stable32

@backportbot
Copy link

backportbot bot commented Dec 1, 2025

The backport to stable32 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable32
git pull origin stable32

# Create the new backport branch
git checkout -b backport/56278/stable32

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick d32878e6 8d8f5f43

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/56278/stable32

Error: Failed to check for changes with origin/stable32: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Share links: password check box is always checked in "Customize link" UI

7 participants