Skip to content

Conversation

@julien-nc
Copy link
Member

Change 'null' download permission to 'true'.
A 'null' download permission has been seen in some team shares in the past. Now that such shares are not created anymore, the ones that were created before the fix are still hanging there.

The problem is that there is a behaviour inconsistency when this permission is null:

  • when editing the share (from the share author point of view) the download is allowed
  • from the receiver point of view, the file cannot be downloaded (the download button is not displayed in the UI)

Should this migration rather be in the files_sharing app?

@julien-nc julien-nc added this to the Nextcloud 33 milestone Nov 6, 2025
@julien-nc julien-nc requested a review from a team as a code owner November 6, 2025 12:31
@julien-nc julien-nc added the bug label Nov 6, 2025
@julien-nc julien-nc requested review from icewind1991, leftybournes and salmart-dev and removed request for a team November 6, 2025 12:31
@julien-nc julien-nc force-pushed the fix/noid/share-permissions-attribute branch from 7f0379e to 43ee50e Compare November 6, 2025 12:34
Copy link
Member

@ArtificialOwl ArtificialOwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

attributes are not indexed, maybe a check on share_type=7 for faster operation ?

@julien-nc julien-nc force-pushed the fix/noid/share-permissions-attribute branch 2 times, most recently from 197c1ef to cd79e73 Compare November 7, 2025 09:06
@julien-nc
Copy link
Member Author

@ArtificialOwl Done, thanks

@julien-nc julien-nc force-pushed the fix/noid/share-permissions-attribute branch from cd79e73 to e4414c4 Compare November 12, 2025 12:38
@julien-nc julien-nc force-pushed the fix/noid/share-permissions-attribute branch 4 times, most recently from 130caab to efa639f Compare November 14, 2025 16:22
…ll' download permission to 'true'

Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc julien-nc force-pushed the fix/noid/share-permissions-attribute branch from efa639f to 8b3e59f Compare November 17, 2025 09:07
@sorbaugh sorbaugh merged commit 3a26574 into master Nov 17, 2025
237 of 251 checks passed
@sorbaugh sorbaugh deleted the fix/noid/share-permissions-attribute branch November 17, 2025 13:07
@blizzz
Copy link
Member

blizzz commented Nov 17, 2025

@nickvergessen
Copy link
Member

@nextcloud-bot nextcloud-bot mentioned this pull request Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants