Skip to content

Conversation

@skjnldsv
Copy link
Member

Fix #50929

This facilitate a bit as we now try to fetch one extra level, so when we expand one folder on the folder tree, we know a bit more about the children and can earlier decide whether to show the expand button or not

image

@skjnldsv skjnldsv added this to the Nextcloud 33 milestone Oct 29, 2025
@skjnldsv skjnldsv self-assigned this Oct 29, 2025
@skjnldsv skjnldsv requested a review from a team as a code owner October 29, 2025 08:43
@skjnldsv skjnldsv added the bug label Oct 29, 2025
@skjnldsv skjnldsv requested review from artonge, sorbaugh and szaimen and removed request for a team October 29, 2025 08:43
@skjnldsv skjnldsv added 3. to review Waiting for reviews feature: files labels Oct 29, 2025
@github-project-automation github-project-automation bot moved this to 🏗️ In progress in 📁 Files team Oct 29, 2025
@skjnldsv
Copy link
Member Author

/backport to stable32

@skjnldsv
Copy link
Member Author

/backport to stable31

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense but did not test

Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the logic.

Given:

_A
 |_B
   |_C

On load, I get the content of A and B, right?
Then, if I toggle B, I get the content of B and C?

So we get B twice?

Might not be that an issue, but if there is an easy way to optimise, maybe we should :).

@skjnldsv
Copy link
Member Author

So we get B twice?

Might not be that an issue, but if there is an easy way to optimise, maybe we should :).

Yes, but it's at least better to ensure up-to-date data. I'm afraid ignoring the current but fetching n+1 only would lead to side effects we haven't thought of

@skjnldsv
Copy link
Member Author

/compile rebase

@nextcloud-command nextcloud-command force-pushed the fix/files-preload-tree-level-2 branch from fa0107c to 638d75d Compare October 31, 2025 17:06
@skjnldsv
Copy link
Member Author

skjnldsv commented Nov 4, 2025

/compile rebase

@nextcloud-command nextcloud-command force-pushed the fix/files-preload-tree-level-2 branch from 638d75d to 5fd63b3 Compare November 4, 2025 09:30
@skjnldsv skjnldsv force-pushed the fix/files-preload-tree-level-2 branch from 5fd63b3 to b68edea Compare November 5, 2025 08:07
@skjnldsv
Copy link
Member Author

skjnldsv commented Nov 6, 2025

/compile rebase

@nextcloud-command nextcloud-command force-pushed the fix/files-preload-tree-level-2 branch from b68edea to b839243 Compare November 6, 2025 15:28
@skjnldsv skjnldsv merged commit 52f99e6 into master Nov 6, 2025
122 of 123 checks passed
@skjnldsv skjnldsv deleted the fix/files-preload-tree-level-2 branch November 6, 2025 15:40
@backportbot
Copy link

backportbot bot commented Nov 6, 2025

The backport to stable31 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable31
git pull origin stable31

# Create the new backport branch
git checkout -b backport/56075/stable31

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick c521b7ca b839243c

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/56075/stable31

Error: Failed to check for changes with origin/stable31: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot
Copy link

backportbot bot commented Nov 6, 2025

The backport to stable32 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable32
git pull origin stable32

# Create the new backport branch
git checkout -b backport/56075/stable32

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick c521b7ca b839243c

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/56075/stable32

Error: Failed to check for changes with origin/stable32: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@skjnldsv
Copy link
Member Author

skjnldsv commented Nov 6, 2025

/backport b7f950c to stable32

@skjnldsv
Copy link
Member Author

skjnldsv commented Nov 6, 2025

/backport b7f950c to stable31

@backportbot
Copy link

backportbot bot commented Nov 6, 2025

The backport to stable32 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable32
git pull origin stable32

# Create the new backport branch
git checkout -b backport/56075/stable32

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick b7f950c

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/56075/stable32

Error: Failed to check for changes with origin/stable32: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot
Copy link

backportbot bot commented Nov 6, 2025

The backport to stable31 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable31
git pull origin stable31

# Create the new backport branch
git checkout -b backport/56075/stable31

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick b7f950c

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/56075/stable31

Error: Failed to check for changes with origin/stable31: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@nextcloud-bot nextcloud-bot mentioned this pull request Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: 🏗️ In progress

Development

Successfully merging this pull request may close these issues.

[Bug]: Folders navigation has expand button when there is no children

5 participants