-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
fix(files): preload file tree with 2 level deep #56075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/backport to stable32 |
|
/backport to stable31 |
szaimen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense but did not test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about the logic.
Given:
_A
|_B
|_C
On load, I get the content of A and B, right?
Then, if I toggle B, I get the content of B and C?
So we get B twice?
Might not be that an issue, but if there is an easy way to optimise, maybe we should :).
Yes, but it's at least better to ensure up-to-date data. I'm afraid ignoring the current but fetching n+1 only would lead to side effects we haven't thought of |
|
/compile rebase |
fa0107c to
638d75d
Compare
|
/compile rebase |
638d75d to
5fd63b3
Compare
5fd63b3 to
b68edea
Compare
|
/compile rebase |
Signed-off-by: skjnldsv <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
b68edea to
b839243
Compare
|
The backport to # Switch to the target branch and update it
git checkout stable31
git pull origin stable31
# Create the new backport branch
git checkout -b backport/56075/stable31
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick c521b7ca b839243c
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/56075/stable31Error: Failed to check for changes with origin/stable31: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
The backport to # Switch to the target branch and update it
git checkout stable32
git pull origin stable32
# Create the new backport branch
git checkout -b backport/56075/stable32
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick c521b7ca b839243c
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/56075/stable32Error: Failed to check for changes with origin/stable32: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
/backport b7f950c to stable32 |
|
/backport b7f950c to stable31 |
|
The backport to # Switch to the target branch and update it
git checkout stable32
git pull origin stable32
# Create the new backport branch
git checkout -b backport/56075/stable32
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick b7f950c
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/56075/stable32Error: Failed to check for changes with origin/stable32: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
The backport to # Switch to the target branch and update it
git checkout stable31
git pull origin stable31
# Create the new backport branch
git checkout -b backport/56075/stable31
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick b7f950c
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/56075/stable31Error: Failed to check for changes with origin/stable31: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Fix #50929
This facilitate a bit as we now try to fetch one extra level, so when we expand one folder on the folder tree, we know a bit more about the children and can earlier decide whether to show the expand button or not