fix(theming): use IAppConfig for all ThemingDefaults #56039
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
force-pushed
the
fix/theming-legacy-app-config
branch
2 times, most recently
from
323b933 to
6676b95
Compare
Fixes issues where values have the wrong type. Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/theming-legacy-app-config
branch
from
6676b95 to
4667634
Compare
susnux
requested review from
ArtificialOwl,
CarlSchwan,
leftybournes,
salmart-dev and
yemkareems
and removed request for
a team
Contributor
Author
|
/backport to stable32 |
artonge
approved these changes
Oct 28, 2025
Contributor
artonge
left a comment
artonge
left a comment
There was a problem hiding this comment.
Might be a good opportunity to also use lib/private/AppFramework/Services/AppConfig.php which pre-fills the app name.
…vices\IAppConfig` Signed-off-by: Ferdinand Thiessen <[email protected]>
Contributor
Author
|
@artonge done |
CarlSchwan
approved these changes
Nov 1, 2025
Contributor
|
@susnux can we backport this to Nextcloud 31? |
Contributor
Author
|
/backport to stable31 |
1 similar comment
Contributor
|
/backport to stable31 |
2 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issues where values have the wrong type.
Checklist
3. to review, feature component)stable32)