-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
feat(TaskProcessingApiController): Add new next_batch endpoint #55735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Marcel Klehr <[email protected]>
bd38af7 to
80eb3dd
Compare
… next_batch endpoint in order to avoid hitting the DB with multiple 1 row requests Signed-off-by: Marcel Klehr <[email protected]>
julien-nc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit of nitpick but Lgtm.
oleksandr-nc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks very nice and robust! 🚀
Signed-off-by: Marcel Klehr <[email protected]>
kyteinsky
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Signed-off-by: Marcel Klehr <[email protected]>
Summary
This adds a new endpoint to return multiple new tasks at once. I opted for a new edpoint instead of extending the existing endpoint, because I feared that the signature would become too convoluted.
Checklist
3. to review, feature component)stable32)