Skip to content

Conversation

@CarlSchwan
Copy link
Member

Summary

Remove all calls to the following APIs:

  • IQueryBuilder::execute
  • Table::hasPrimaryKey
  • Type::getName

And from the following pattern:

getDatabasePlatform() instanceof

Checklist

@CarlSchwan CarlSchwan force-pushed the carl/deprecated-dbal branch 2 times, most recently from 977f88c to 5e5e075 Compare October 12, 2025 09:38
@CarlSchwan CarlSchwan marked this pull request as ready for review October 13, 2025 11:12
@CarlSchwan CarlSchwan requested review from ArtificialOwl, provokateurin and salmart-dev and removed request for a team October 13, 2025 11:12
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, but I think you need to run cs:fix on the 3rd commit, as some of the imports are only removed in the 4th commit where they don't belong.

@CarlSchwan CarlSchwan force-pushed the carl/deprecated-dbal branch from 5e5e075 to 49d5227 Compare October 13, 2025 11:44
@CarlSchwan CarlSchwan enabled auto-merge October 13, 2025 11:44
@CarlSchwan CarlSchwan merged commit 65f52c4 into master Oct 13, 2025
208 of 216 checks passed
@CarlSchwan CarlSchwan deleted the carl/deprecated-dbal branch October 13, 2025 13:10
@nextcloud-bot nextcloud-bot mentioned this pull request Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants