refactor: Deprecated user config from IConfig correctly #55631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlSchwan
force-pushed
the
carl/deprecate-config-user-correctly
branch
3 times, most recently
from
7005234 to
e28f8bc
Compare
CarlSchwan
requested review from
come-nc,
nfebe and
sorbaugh
and removed request for
a team
CarlSchwan
force-pushed
the
carl/deprecate-config-user-correctly
branch
from
e28f8bc to
dc80259
Compare
CarlSchwan
force-pushed
the
carl/deprecate-config-user-correctly
branch
from
b896252 to
3012f70
Compare
come-nc
reviewed
Oct 13, 2025
CarlSchwan
force-pushed
the
carl/deprecate-config-user-correctly
branch
from
3012f70 to
6f13b12
Compare
CarlSchwan
requested review from
ChristophWurst,
SebastianKrupinski and
tcitworld
as code owners
CarlSchwan
force-pushed
the
carl/deprecate-config-user-correctly
branch
from
6f13b12 to
82b301a
Compare
CarlSchwan
added
3. to review
CarlSchwan
force-pushed
the
carl/deprecate-config-user-correctly
branch
3 times, most recently
from
ea9ee80 to
5db576f
Compare
miaulalala
reviewed
Dec 10, 2025
CarlSchwan
force-pushed
the
carl/deprecate-config-user-correctly
branch
from
5db576f to
6bb366a
Compare
provokateurin
requested changes
Dec 10, 2025
Member
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
LGTM, just one minor detail 😅
CarlSchwan
force-pushed
the
carl/deprecate-config-user-correctly
branch
from
6bb366a to
5e6cdd5
Compare
come-nc
reviewed
Dec 11, 2025
CarlSchwan
force-pushed
the
carl/deprecate-config-user-correctly
branch
from
2251c85 to
c183f55
Compare
Mark the methods in the interface deprecated instead of just the one in the implementation. Signed-off-by: Carl Schwan <[email protected]>
Signed-off-by: Carl Schwan <[email protected]>
Signed-off-by: Carl Schwan <[email protected]>
Signed-off-by: Carl Schwan <[email protected]>
The implementation was deprecated in 31.0.0 but since this wasn't done on the interface, this is considered invalid. So change that to 33.0.0. Signed-off-by: Carl Schwan <[email protected]>
- Use PHP_FLOAT_EPSILON for float comparaison - Simplify some getValueBool code Signed-off-by: Carl Schwan <[email protected]>
CarlSchwan
force-pushed
the
carl/deprecate-config-user-correctly
branch
from
c183f55 to
1661855
Compare
come-nc
approved these changes
Dec 11, 2025
provokateurin
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark the methods in the interface deprecated instead of just the one in the implementation.
Summary
Mark the methods in the interface deprecated instead of just the one in the implementation.
One of them was not on the public interface, so I directly removed it and ported the only usage.
Checklist
3. to review, feature component)stable32)