refactor(IPropagator): Cleanup implementation #55629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add missing type hinting - Use only public methods from IStorage instead of relying on internal \OC\Storage methods - Refactor HomePropagator to use ignore argument from Propagator instead of reimplementing the same logic. Signed-off-by: Carl Schwan <[email protected]>
CarlSchwan
force-pushed
the
carl/cleanup-propagator
branch
from
518fa13 to
475c847
Compare
CarlSchwan
requested review from
Altahrim,
come-nc and
sorbaugh
and removed request for
a team
susnux
approved these changes
Oct 13, 2025
come-nc
approved these changes
Oct 13, 2025
| private readonly IDBConnection $connection, | ||
| private readonly array $ignore = [], | ||
| ) { | ||
| $this->clock = Server::get(ClockInterface::class); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist
3. to review, feature component)stable32)