-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Update Nextcloud Devcontainer #55527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
068b07a to
5758515
Compare
szaimen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐘
CarlSchwan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sane
|
@R0Wi please use conventional commits then this should be good to merge. |
Removed deprecations: * docker-compose version * apt-key add command in docker installation Updates: * Upgrade from PHP8.3 to PHP8.4 (currently recommended for NC) from ppa:ondrej/php * Use nodejs 22 by default Optimization: * Just install docker-ce-cli, not the full docker suite (speeds up docker build) * Make sure user "devcontainer" has UID 1000. This increases the containers filesystem compatibility to most (unix-based) host systems because the default user there always has 1000 as well * Ensure devcontainer user has access to docker without sudo Signed-off-by: Robin Windey <[email protected]>
8ad3712 to
88fde78
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Summary
Removed deprecations
Updates
Optimization
TODO
Checklist
3. to review, feature component)stable32)