Skip to content

Conversation

@R0Wi
Copy link
Member

@R0Wi R0Wi commented Oct 3, 2025

Summary

Removed deprecations

  • docker-compose version
  • apt-key add command in docker installation

Updates

  • Upgrade from PHP8.3 to PHP8.4 (currently recommended for NC) from ppa:ondrej/php
  • Use nodejs 20 by default

Optimization

  • Just install docker-ce-cli, not the full docker suite (speeds up docker build)
  • Make sure user "devcontainer" has UID 1000. This increases the containers filesystem compatibility to most (unix-based) host systems because the default user there always has 1000 as well
  • Ensure devcontainer user has access to docker without sudo

TODO

  • ...

Checklist

@R0Wi R0Wi requested a review from a team as a code owner October 3, 2025 08:17
@R0Wi R0Wi requested review from CarlSchwan, leftybournes and yemkareems and removed request for a team October 3, 2025 08:17
@R0Wi R0Wi force-pushed the feature/update-devcontainer branch from 068b07a to 5758515 Compare October 3, 2025 08:17
@susnux susnux added this to the Nextcloud 33 milestone Oct 3, 2025
@susnux susnux requested a review from szaimen October 3, 2025 16:11
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

Copy link
Member

@CarlSchwan CarlSchwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane

@susnux
Copy link
Contributor

susnux commented Oct 6, 2025

@R0Wi please use conventional commits then this should be good to merge.

Removed deprecations:
* docker-compose version
* apt-key add command in docker installation

Updates:
* Upgrade from PHP8.3 to PHP8.4 (currently recommended for NC) from ppa:ondrej/php
* Use nodejs 22 by default

Optimization:
* Just install docker-ce-cli, not the full docker suite (speeds up docker build)
* Make sure user "devcontainer" has UID 1000. This increases the containers filesystem compatibility to most (unix-based) host systems because the default user there always has 1000 as well
* Ensure devcontainer user has access to docker without sudo

Signed-off-by: Robin Windey <[email protected]>
@R0Wi R0Wi force-pushed the feature/update-devcontainer branch from 8ad3712 to 88fde78 Compare October 7, 2025 04:38
@R0Wi R0Wi enabled auto-merge October 7, 2025 04:39
@R0Wi R0Wi merged commit d84d6ca into master Oct 7, 2025
125 checks passed
@R0Wi R0Wi deleted the feature/update-devcontainer branch October 7, 2025 04:56
@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants