refactor: Cleanup some unit tests #55405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlSchwan
requested review from
Altahrim,
come-nc and
sorbaugh
and removed request for
a team
come-nc
reviewed
Sep 30, 2025
come-nc
approved these changes
Sep 30, 2025
CarlSchwan
force-pushed
the
carl/cleanup-some-tests
branch
from
d9322d1 to
a3909b8
Compare
- use declare(strict_types=1) - use strong typing - Remove some weird things in ControllerTest Signed-off-by: Carl Schwan <[email protected]>
CarlSchwan
force-pushed
the
carl/cleanup-some-tests
branch
from
a3909b8 to
60c2875
Compare
susnux
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
3. to review, feature component)stable32)