Skip to content

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Sep 28, 2025

Summary

Another place to get rid of legacy stuff 🧹

Checklist

@susnux susnux added 3. to review Waiting for reviews technical debt ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Sep 28, 2025
@susnux susnux added this to the Nextcloud 33 milestone Sep 28, 2025
@susnux susnux force-pushed the refactor/files_external-ajax branch from a45f43e to 421dc20 Compare September 28, 2025 12:22
@susnux susnux marked this pull request as ready for review September 28, 2025 12:22
@susnux susnux requested review from a team and skjnldsv as code owners September 28, 2025 12:22
@susnux susnux requested review from Altahrim, CarlSchwan, come-nc, nfebe, provokateurin and szaimen and removed request for a team, nfebe and szaimen September 28, 2025 12:22
@susnux susnux force-pushed the refactor/files_external-ajax branch from 421dc20 to 92a8bc4 Compare September 28, 2025 13:31
@come-nc
Copy link
Contributor

come-nc commented Sep 28, 2025

failures related

There were 4 failures:

1) Test\UrlGeneratorTest::testLinkToDocRoot with data set #0 ('files_external', 'ajax/oauth2.php', [], '/index.php/apps/files_externa...h2.php')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'/index.php/apps/files_external/ajax/oauth2.php'
+'/files_external/ajax/oauth2.php'

/home/runner/work/server/server/tests/lib/UrlGeneratorTest.php:79

2) Test\UrlGeneratorTest::testLinkToDocRoot with data set #1 ('files_external', 'ajax/oauth2.php', ['trat', 'dat'], '/index.php/apps/files_externa...ut=dat')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'/index.php/apps/files_external/ajax/oauth2.php?trut=trat&dut=dat'
+'/files_external/ajax/oauth2.php?trut=trat&dut=dat'

/home/runner/work/server/server/tests/lib/UrlGeneratorTest.php:79

3) Test\UrlGeneratorTest::testLinkToSubDir with data set #0 ('files_external', 'ajax/oauth2.php', [], '/nextcloud/index.php/apps/fil...h2.php')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'/nextcloud/index.php/apps/files_external/ajax/oauth2.php'
+'/nextcloud/files_external/ajax/oauth2.php'

/home/runner/work/server/server/tests/lib/UrlGeneratorTest.php:90

4) Test\UrlGeneratorTest::testLinkToSubDir with data set #1 ('files_external', 'ajax/oauth2.php', ['trat', 'dat'], '/nextcloud/index.php/apps/fil...ut=dat')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'/nextcloud/index.php/apps/files_external/ajax/oauth2.php?trut=trat&dut=dat'
+'/nextcloud/files_external/ajax/oauth2.php?trut=trat&dut=dat'

/home/runner/work/server/server/tests/lib/UrlGeneratorTest.php:90

@susnux susnux force-pushed the refactor/files_external-ajax branch from 519c6ef to be88bb6 Compare September 28, 2025 23:40
@come-nc
Copy link
Contributor

come-nc commented Sep 29, 2025

update-baseline is missing. And /compile?

@susnux susnux force-pushed the refactor/files_external-ajax branch 2 times, most recently from cda2c9c to 9eecf78 Compare September 30, 2025 08:55
@susnux susnux force-pushed the refactor/files_external-ajax branch from 9eecf78 to d20d4d3 Compare September 30, 2025 18:19
@provokateurin provokateurin merged commit 7b60e3d into master Sep 30, 2025
202 checks passed
@provokateurin provokateurin deleted the refactor/files_external-ajax branch September 30, 2025 18:39
@nextcloud-bot nextcloud-bot mentioned this pull request Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) technical debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants