Skip to content

Conversation

@mickenordin
Copy link
Contributor

I noticed that I was mentioned twice in the AUTHORS file, so this patch removes the one that should not be there.

The correct one is Micke Nordin <[email protected]> a few lines up.

@mickenordin mickenordin requested a review from a team as a code owner September 24, 2025 10:12
@mickenordin mickenordin requested review from Altahrim, come-nc and yemkareems and removed request for a team September 24, 2025 10:12
@kesselb
Copy link
Contributor

kesselb commented Sep 24, 2025

Thanks 🙏

Please also add a mapping to https://github.com/nextcloud/server/blob/master/.mailmap.

I'm not sure if it's still relevant, but we had a script to update that authors file, and that script also added the line you are about to remove. So if we ever run it again, it might be re-added along without the mapping.

@mickenordin
Copy link
Contributor Author

Thanks 🙏

Please also add a mapping to https://github.com/nextcloud/server/blob/master/.mailmap.

I'm not sure if it's still relevant, but we had a script to update that authors file, and that script also added the line you are about to remove. So if we ever run it again, it might be re-added along without the mapping.

Does that look correct?

@kesselb kesselb added the 3. to review Waiting for reviews label Sep 24, 2025
@mickenordin mickenordin force-pushed the master branch 2 times, most recently from 773d87e to 8dc87e2 Compare September 25, 2025 07:12
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 25, 2025
@kesselb kesselb merged commit fab035e into nextcloud:master Sep 25, 2025
111 of 114 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2025

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish feedback-requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants