Skip to content

Conversation

@yemkareems
Copy link
Contributor

fix: added 3 new light images for facebook, bluesky and mastodon and added them in REUSE.toml

  • Resolves: #

Summary

TODO

  • ...

Checklist

@yemkareems yemkareems self-assigned this Sep 23, 2025
@yemkareems yemkareems requested a review from a team as a code owner September 23, 2025 12:17
@yemkareems yemkareems added the 3. to review Waiting for reviews label Sep 23, 2025
@yemkareems yemkareems requested review from icewind1991 and sorbaugh and removed request for a team September 23, 2025 12:17
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other icons are not really "dark" icons but no color icons.
IMHO here all official logos then should be used also for e.g. X and then also directly used in the settings page.

@AndyScherzinger
Copy link
Member

I agree with @susnux - we can just use the colored ones in both cases - also given due to the fact that i.e. facebook only allows for this specific one, no matter dark or light theming.

CarlSchwan
CarlSchwan previously approved these changes Sep 24, 2025
@CarlSchwan CarlSchwan dismissed their stale review September 24, 2025 09:08

didn't saw the comments

@yemkareems
Copy link
Contributor Author

Added two new images for x dark and light and switched them based on isDarkTheme flag.

@yemkareems yemkareems requested a review from susnux September 25, 2025 10:44
@yemkareems
Copy link
Contributor Author

Settings page also use brand images

Screenshot from 2025-09-25 19-59-02 Screenshot from 2025-09-25 19-59-25

@AndyScherzinger AndyScherzinger merged commit 1e492e6 into master Sep 28, 2025
211 of 213 checks passed
@AndyScherzinger AndyScherzinger deleted the fix/add-light-images-for-fb-bsky-mastodon branch September 28, 2025 21:16
@AndyScherzinger AndyScherzinger added this to the Nextcloud 33 milestone Sep 28, 2025
@AndyScherzinger
Copy link
Member

/backport to stable32

@backportbot
Copy link

backportbot bot commented Sep 28, 2025

The backport to stable32 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable32
git pull origin stable32

# Create the new backport branch
git checkout -b backport/55269/stable32

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 59609024 33cd89db a3e8f00f

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/55269/stable32

Error: Failed to clone repository: Failed to clone and cache repo: EACCES: permission denied, mkdir '/app/cache/nextcloud/server'


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@nextcloud-bot nextcloud-bot mentioned this pull request Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants