feat(db): Restaure support for non-nullable boolean column #55156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We disabled them because they are not supported on Oracle DB and it is still the case for OCI < 23. But instead of disabling the support completely for every database types, mark non-nullable boolean column as actually nullable when using Oracle. This allow to use some slighly lighter schema on normal databases who support natively booleans wheen we don't need to store 3 states true|false|null. Signed-off-by: Carl Schwan <[email protected]>
CarlSchwan
requested review from
Altahrim,
come-nc and
icewind1991
and removed request for
a team
Altahrim
approved these changes
Sep 17, 2025
nickvergessen
approved these changes
Sep 17, 2025
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
I hope this doesn't cause troubles down the street when the target schema is modified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We disabled them because they are not supported on Oracle DB and it is still the case for OCI < 23. But instead of disabling the support completely for every database types, mark non-nullable boolean column as actually nullable when using Oracle.
This allow to use some slighly lighter schema on normal databases who support natively booleans wheen we don't need to store 3 states true|false|null.
Checklist