Skip to content

Conversation

@invario
Copy link
Contributor

@invario invario commented Sep 13, 2025

Improved/additional logging when generating previews for video/movie files at INFO level and always log ffmpeg output to DEBUG (not only when ffmpeg fails/errors).

Checklist

@invario invario requested a review from a team as a code owner September 13, 2025 01:32
@invario invario requested review from CarlSchwan, icewind1991 and yemkareems and removed request for a team September 13, 2025 01:32
@AndyScherzinger AndyScherzinger added 3. to review Waiting for reviews 0. Needs triage Pending check for reproducibility or if it fits our roadmap feature: previews and thumbnails feature: logging and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Sep 14, 2025
@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@invario
Copy link
Contributor Author

invario commented Oct 14, 2025

@provokateurin If you have the time, any chance of taking a look at this please?

@provokateurin
Copy link
Member

Sorry yes, it somehow slipped past me!

Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor changes I would do to avoid spammy logs.

@invario invario force-pushed the previews-better-logging branch from 7d98bf1 to 13500be Compare October 14, 2025 17:17
@invario
Copy link
Contributor Author

invario commented Oct 14, 2025

LGTM, just some minor changes I would do to avoid spammy logs.

Thanks, pushed changes!

@sorbaugh sorbaugh merged commit 567a988 into nextcloud:master Oct 15, 2025
174 of 177 checks passed
@provokateurin
Copy link
Member

/backport to stable32

@invario invario deleted the previews-better-logging branch October 15, 2025 12:35
@nextcloud-bot nextcloud-bot mentioned this pull request Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants