-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
feat(previews): improved logging for movie previews #55100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
|
@provokateurin If you have the time, any chance of taking a look at this please? |
|
Sorry yes, it somehow slipped past me! |
provokateurin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some minor changes I would do to avoid spammy logs.
Signed-off-by: invario <[email protected]>
7d98bf1 to
13500be
Compare
Thanks, pushed changes! |
|
/backport to stable32 |
Improved/additional logging when generating previews for video/movie files at INFO level and always log
ffmpegoutput to DEBUG (not only whenffmpegfails/errors).Checklist