refactor(preview): Cleanup a bit the public interface #55083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlSchwan
added
3. to review
CarlSchwan
force-pushed
the
carl/preview-interface-cleanup
branch
from
61aefe1 to
bda4966
Compare
CarlSchwan
requested review from
ArtificialOwl,
leftybournes and
yemkareems
and removed request for
a team
come-nc
reviewed
Sep 15, 2025
CarlSchwan
force-pushed
the
carl/preview-interface-cleanup
branch
3 times, most recently
from
0e5414c to
3ef3308
Compare
come-nc
approved these changes
Sep 23, 2025
provokateurin
approved these changes
Sep 26, 2025
CarlSchwan
force-pushed
the
carl/preview-interface-cleanup
branch
from
3ef3308 to
da96798
Compare
* Remove old IProvider interface, it's been deprecated since 17.0.0 (8 years) * Add type hinting to the IPreview interface and mark it as consumeable only * Remove unused arguments from GeneratorHelper Signed-off-by: Carl Schwan <[email protected]>
CarlSchwan
force-pushed
the
carl/preview-interface-cleanup
branch
from
da96798 to
cb82a9e
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist