Skip to content

fix: check if reported size is numeric in file info command #55069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
st3iny wants to merge 1 commit into from
Closed

fix: check if reported size is numeric in file info command #55069

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/Command/Info/File.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@
}
$stat = fstat($fh);
fclose($fh);
if (isset($stat['size']) && $stat['size'] !== $node->getSize()) {
if (isset($stat['size']) && is_numeric($stat['size']) && $stat['size'] !== $node->getSize()) {

Check failure on line 179 in core/Command/Info/File.php

View workflow job for this annotation

GitHub Actions / static-code-analysis

RedundantCondition 

core/Command/Info/File.php:179:34: RedundantCondition: Type int for $stat['size'] is always numeric (see https://psalm.dev/122)

Check failure on line 179 in core/Command/Info/File.php

View workflow job for this annotation

GitHub Actions / static-code-analysis

RedundantCondition 

core/Command/Info/File.php:179:10: RedundantCondition: Type int for $stat['size'] is always numeric (see https://psalm.dev/122)
$output->writeln(' <error>warning: object had a size of ' . $stat['size'] . ' but cache entry has a size of ' . $node->getSize() . '</error>. This should have been automatically repaired');
}
} catch (\Exception $e) {
Expand Down
Loading