refactor(CustomPropertiesBackend): Modernize class #54645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlSchwan
force-pushed
the
carl/modernize-custom-property-backend
branch
2 times, most recently
from
271aa05 to
4c5842e
Compare
CarlSchwan
requested review from
ArtificialOwl,
come-nc and
provokateurin
and removed request for
a team
provokateurin
approved these changes
Aug 26, 2025
Member
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
You might want to add it to build/rector.php and give it a pass.
Member
Author
not sure if I ran it correctly but it didn't found any further issue, but found some issues in other files: #54666 |
Member
|
It won't hurt to add it though, so any future changes to the config will be applied to it. We try to extend the area of the codebase it applies to, so any file that can be added helps. |
come-nc
reviewed
Aug 28, 2025
CarlSchwan
force-pushed
the
carl/modernize-custom-property-backend
branch
from
fa354fd to
4c5842e
Compare
CarlSchwan
force-pushed
the
carl/modernize-custom-property-backend
branch
from
4c5842e to
a6fe11b
Compare
come-nc
approved these changes
Sep 2, 2025
susnux
reviewed
Sep 3, 2025
- Use query builder - Add chunking - Add type hinting where we can - Use match expression Signed-off-by: Carl Schwan <[email protected]> Signed-off-by: Carl Schwan <[email protected]>
CarlSchwan
force-pushed
the
carl/modernize-custom-property-backend
branch
from
a6fe11b to
b303185
Compare
Member
Author
|
@AndyScherzinger can I get a force merge on this :) |
Member
|
@CarlSchwan done, you want or need a backport for 32? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist