feat(settings): Deploy daemon selection support during ExApp installation #53756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrey18106
requested review from
nfebe,
sorbaugh and
susnux
and removed request for
a team
susnux
added
enhancement
3. to review
susnux
reviewed
Jul 2, 2025
susnux
reviewed
Jul 2, 2025
susnux
reviewed
Jul 2, 2025
apps/settings/src/components/AppStoreSidebar/AppDeployOptionsModal.vue
Outdated
Show resolved
Hide resolved
andrey18106
force-pushed
the
feat/settings/app_api/daemon-selection
branch
from
65c381a to
091bf26
Compare
oleksandr-nc
approved these changes
Jul 25, 2025
skjnldsv
added
2. developing
Member
|
Some comments to address it seems |
…tion Signed-off-by: Andrey Borysenko <[email protected]>
andrey18106
force-pushed
the
feat/settings/app_api/daemon-selection
branch
from
091bf26 to
71ef47e
Compare
kesselb
added
4. to release
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR migrates UI part from nextcloud/app_api#394 to Apps management for ExApps.
Daemon selection modal is shown only if more than 1
docker-installdaemons configured on ExApp install action.Requires: nextcloud/app_api#607.
TODO
Checklist