Skip to content

[stable30] fix(files_sharing): Stop hiding delete share button in advanced settings menu #53723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
provokateurin merged 2 commits into from
Jun 30, 2025
Merged

[stable30] fix(files_sharing): Stop hiding delete share button in advanced settings menu #53723

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9011a1
fix(files_sharing): Stop hiding delete share button in advanced setti…
provokateurin Jun 23, 2025
7d0d8cb
chore(assets): Recompile assets
nextcloud-command Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions apps/files_sharing/src/views/SharingDetailsTab.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,19 +208,6 @@
{{ t('files_sharing', 'Delete') }}
</NcCheckboxRadioSwitch>
</section>
<div class="sharingTabDetailsView__delete">
<NcButton v-if="!isNewShare"
:aria-label="t('files_sharing', 'Delete share')"
:disabled="false"
:readonly="false"
type="tertiary"
@click.prevent="removeShare">
<template #icon>
<CloseIcon :size="16" />
</template>
{{ t('files_sharing', 'Delete share') }}
</NcButton>
</div>
</section>
</div>
</div>
Expand All @@ -231,6 +218,19 @@
@click="$emit('close-sharing-details')">
{{ t('files_sharing', 'Cancel') }}
</NcButton>
<div class="sharingTabDetailsView__delete">
<NcButton v-if="!isNewShare"
:aria-label="t('files_sharing', 'Delete share')"
:disabled="false"
:readonly="false"
variant="tertiary"
@click.prevent="removeShare">
<template #icon>
<CloseIcon :size="20" />
</template>
{{ t('files_sharing', 'Delete share') }}
</NcButton>
</div>
<NcButton type="primary"
data-cy-files-sharing-share-editor-action="save"
:disabled="creating"
Expand Down
Loading