fix: make ScheduledNotifications a TimedJob and run every minute #53421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salmart-dev
requested review from
artonge,
nfebe and
provokateurin
and removed request for
a team
apps/files_reminders/lib/BackgroundJob/ScheduledNotifications.php
Outdated
Show resolved
Hide resolved
provokateurin
approved these changes
Jun 13, 2025
salmart-dev
changed the title
salmart-dev
force-pushed
the
fix/convert-schedulednotifications-to-timedjob
branch
from
132dd72 to
b350650
Compare
run every 1s. Signed-off-by: Salvatore Martire <[email protected]>
salmart-dev
force-pushed
the
fix/convert-schedulednotifications-to-timedjob
branch
from
b350650 to
dc041c5
Compare
nickvergessen
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is a follow-up to address issues discovered while investigating issue #49584
When running
occ background-job:worker, some jobs can be seen running constantly andScheduledNotificationsis one of them. It should be safe to run the rotation job every second.Checklist