Skip to content

fix(dav): handle uploading folders with names of existing file for file drop plugin #52821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
susnux merged 2 commits into from
May 16, 2025
Merged

fix(dav): handle uploading folders with names of existing file for file drop plugin #52821

susnux merged 2 commits into from
May 16, 2025

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented May 14, 2025 •
edited
Loading

Summary

This PR does two things:

  1. Migrate from private file view API to the File Node API
  2. Fix an issue if you upload first a file (e.g. "file") and afterwards a folder (called "files) with the same name.
    In this case the folder needs to get a new unique name as we cannot rename the file (missing permission).

Checklist

@susnux susnux added this to the Nextcloud 32 milestone May 14, 2025
@susnux susnux requested a review from a team as a code owner May 14, 2025 15:43
@susnux susnux requested review from icewind1991 and yemkareems and removed request for a team May 14, 2025 15:43
@susnux susnux added the bug label May 14, 2025
@susnux susnux requested a review from provokateurin May 14, 2025 15:43
@susnux susnux requested review from come-nc and skjnldsv May 14, 2025 15:44
@susnux susnux merged commit 14023cc into master May 16, 2025
197 of 211 checks passed
@susnux susnux deleted the fix/file-drop branch May 16, 2025 13:38
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@icewind1991 icewind1991 icewind1991 approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@provokateurin provokateurin provokateurin approved these changes

@yemkareems yemkareems Awaiting requested review from yemkareems yemkareems is a code owner automatically assigned from nextcloud/server-backend

@come-nc come-nc Awaiting requested review from come-nc

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug feature: dav feature: sharing

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

5 participants

@susnux @icewind1991 @skjnldsv @provokateurin