fix(login): only show error state on login box if user interacted #50798
+8
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
bug
design
Contributor
Author
|
/backport to stable31 |
Contributor
Author
|
/backport to stable30 |
Contributor
Author
|
/backport to stable29 |
Pytal
reviewed
Feb 13, 2025
Member
Pytal
left a comment
Pytal
left a comment
There was a problem hiding this comment.
Would it make sense to upstream this in NcInputField or make it a prop?
Pytal
approved these changes
Feb 13, 2025
skjnldsv
approved these changes
Feb 14, 2025
szaimen
approved these changes
Feb 14, 2025
Contributor
szaimen
left a comment
szaimen
left a comment
There was a problem hiding this comment.
LGTM from the screebshot. Thanks for fixing this! :)
susnux
force-pushed
the
fix/login-error-state
branch
from
732f894 to
61d9100
Compare
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/login-error-state
branch
from
61d9100 to
1138fd3
Compare
This was referenced Feb 17, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The input fields should only marked as invalid visually if the user interacted with them (e.g. entered something or tried to submit them empty).
Screenshots
Checklist