Skip to content

Conversation

@provokateurin
Copy link
Member

Summary

When executing the script all the app/*/composer/composer/installed.php files change as they reference the current HEAD commit hash. To avoid having to manually discard the changes, just drop them automatically.

Checklist

@provokateurin provokateurin added the 3. to review Waiting for reviews label Oct 17, 2024
@provokateurin provokateurin added this to the Nextcloud 31 milestone Oct 17, 2024
@provokateurin provokateurin requested review from a team, ArtificialOwl, artonge and nfebe and removed request for a team October 17, 2024 07:26
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there no option to prevent those updates in the first place?
Approved, as fine with this solution thought.

@susnux
Copy link
Contributor

susnux commented Oct 21, 2024

Is there no option to prevent those updates in the first place?

Skip the composer install ... part and only run composer dump-autoload ....

@provokateurin
Copy link
Member Author

Skip the composer install ... part and only run composer dump-autoload ....

I wonder if not doing it could cause any problems. I don't see why we need to do it first before dumping the autoloaders, so we might just get rid of it in the first place?

@provokateurin
Copy link
Member Author

I wonder if not doing it could cause any problems. I don't see why we need to do it first before dumping the autoloaders, so we might just get rid of it in the first place?

I checked and it is necessary, so this is the way to go for now.

@provokateurin provokateurin merged commit 582af10 into master Oct 22, 2024
@provokateurin provokateurin deleted the build/autoloader/remove-noisy-changes branch October 22, 2024 09:20
@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants