Skip to content

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Sep 20, 2024

Summary

Now that we have the Vue UI everywhere lets remove all legacy scripts and styles.
For the styles there might be regressions, but I could not spot any yet, so lets go with it as early as possible!

Also for the scripts there is only one "valid" use case: Legacy sidebar tabs that were deprecated 5 (!) years ago, so nothing to worry about I would expect.

Checklist

@susnux susnux added 3. to review Waiting for reviews feature: files technical debt ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Sep 20, 2024
@susnux susnux added this to the Nextcloud 31 milestone Sep 20, 2024
@susnux susnux requested a review from a team September 20, 2024 11:50
@susnux susnux requested a review from skjnldsv as a code owner September 20, 2024 11:50
@susnux susnux requested review from nfebe, sorbaugh and szaimen and removed request for a team September 20, 2024 11:50
@szaimen szaimen removed their request for review September 20, 2024 12:05
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing cleanup ❤️

Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@susnux
Copy link
Contributor Author

susnux commented Sep 20, 2024

/compile

Signed-off-by: nextcloud-command <[email protected]>
@provokateurin provokateurin merged commit 74bfca4 into master Sep 20, 2024
@provokateurin provokateurin deleted the chore/remove-legacy-files-scripts branch September 20, 2024 15:36
@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews feature: files ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) technical debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants