Skip to content

chore: Remove deprecated IJob::execute method #48197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
susnux merged 1 commit into from
Sep 9, 2025
Merged

chore: Remove deprecated IJob::execute method #48197

susnux merged 1 commit into from
Sep 9, 2025

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Sep 18, 2024 •
edited
Loading

Summary

IJob::execute is deprecated for quite some time and ILogger does not provide any logging functions anymore.
Now after 3 years we can remove it with Nextcloud 33.

Checklist

@susnux susnux added this to the Nextcloud 33 milestone Sep 18, 2024
@susnux susnux requested a review from come-nc September 18, 2024 22:40
susnux
susnux commented Sep 18, 2024
View reviewed changes
susnux
susnux commented Sep 18, 2024
View reviewed changes
susnux
susnux commented Sep 18, 2024
View reviewed changes
Base automatically changed from chore/remove-ilogger to master September 19, 2024 08:58
@nickvergessen nickvergessen removed this from the Nextcloud 33 milestone Sep 19, 2024
@skjnldsv skjnldsv added this to the Nextcloud 32 milestone Jan 30, 2025
@come-nc come-nc mentioned this pull request Aug 14, 2025
Closed
24 tasks
@susnux susnux force-pushed the chore/remove-ijob-execute branch from b947685 to b1410ae Compare September 4, 2025 15:28
@susnux
Copy link
Contributor Author

susnux commented Sep 4, 2025

Its time for 33!

@susnux susnux marked this pull request as ready for review September 4, 2025 15:28
@susnux susnux requested a review from a team as a code owner September 4, 2025 15:28
@susnux susnux requested review from CarlSchwan and leftybournes and removed request for a team September 4, 2025 15:28
@susnux susnux added 3. to review Waiting for reviews ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) and removed 2. developing Work in progress labels Sep 4, 2025
@susnux susnux modified the milestones: Nextcloud 32, Nextcloud 33 Sep 4, 2025
@susnux susnux force-pushed the chore/remove-ijob-execute branch from b1410ae to 89896b1 Compare September 4, 2025 15:48
@susnux susnux merged commit 016f2ff into master Sep 9, 2025
210 of 212 checks passed
@susnux susnux deleted the chore/remove-ijob-execute branch September 9, 2025 14:37
@susnux susnux mentioned this pull request Sep 10, 2025
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 33, Nextcloud 32 Oct 2, 2025
@nextcloud-bot nextcloud-bot mentioned this pull request Jan 6, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Altahrim Altahrim Altahrim approved these changes

@come-nc come-nc come-nc approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan CarlSchwan is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

3. to review Waiting for reviews ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) technical debt

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

[Meta]: Port away from ILogger

6 participants

@susnux @Altahrim @come-nc @nickvergessen @skjnldsv