delete share confirmation #46990
Closed
delete share confirmation #46990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [tslib](https://github.com/Microsoft/tslib) from 2.6.2 to 2.6.3. - [Release notes](https://github.com/Microsoft/tslib/releases) - [Commits](microsoft/tslib@v2.6.2...v2.6.3) --- updated-dependencies: - dependency-name: tslib dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [cypress](https://github.com/cypress-io/cypress) from 13.7.1 to 13.7.3. - [Release notes](https://github.com/cypress-io/cypress/releases) - [Changelog](https://github.com/cypress-io/cypress/blob/develop/CHANGELOG.md) - [Commits](cypress-io/cypress@v13.7.1...v13.7.3) --- updated-dependencies: - dependency-name: cypress dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [eslint-plugin-cypress](https://github.com/cypress-io/eslint-plugin-cypress) from 2.15.1 to 2.15.2. - [Release notes](https://github.com/cypress-io/eslint-plugin-cypress/releases) - [Commits](cypress-io/eslint-plugin-cypress@v2.15.1...v2.15.2) --- updated-dependencies: - dependency-name: eslint-plugin-cypress dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
…yarn/stable29/tslib-2.6.3
Bumps [jquery-ui-dist](https://github.com/jquery/jquery-ui) from 1.13.2 to 1.13.3. - [Release notes](https://github.com/jquery/jquery-ui/releases) - [Commits](jquery/jquery-ui@1.13.2...1.13.3) --- updated-dependencies: - dependency-name: jquery-ui-dist dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
…yarn/stable29/jquery-ui-dist-1.13.3
…yarn/stable29/cypress-13.7.3
Bumps [cypress-if](https://github.com/bahmutov/cypress-if) from 1.12.0 to 1.12.3. - [Release notes](https://github.com/bahmutov/cypress-if/releases) - [Commits](bahmutov/cypress-if@v1.12.0...v1.12.3) --- updated-dependencies: - dependency-name: cypress-if dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
…yarn/stable29/cypress-if-1.12.3
Signed-off-by: Daniel Kesselberg <[email protected]> [skip ci]
Patch: wapmorgan/Mp3Info#36 Signed-off-by: Daniel Kesselberg <[email protected]>
…le29 [stable29] fix: Avoid throwing errors for teams are unavailable
…yarn/stable29/eslint-plugin-cypress-2.15.2
…le29 [stable29] chore(mp3info): apply upstream patch for invalid array access
Signed-off-by: Nextcloud bot <[email protected]>
Signed-off-by: Nextcloud bot <[email protected]>
Signed-off-by: Luka Trovic <[email protected]>
…le29 [stable29] fix: csrf check failed on public share with password
Signed-off-by: Nextcloud bot <[email protected]>
Signed-off-by: Git'Fellow <[email protected]> fix: lint Signed-off-by: Git'Fellow <[email protected]> fix: use AwsException Signed-off-by: Git'Fellow <[email protected]> fix: Throw on connection failure Signed-off-by: Git'Fellow <[email protected]> fix: Wrap all in try catch block Signed-off-by: Git'Fellow <[email protected]> fix: use RequestTimeout error message Signed-off-by: Git'Fellow <[email protected]> log: use OCP Server class Signed-off-by: Git'Fellow <[email protected]> fix: Handle connect timeout only Signed-off-by: Git'Fellow <[email protected]> fix: Handle errors more generically Signed-off-by: Git'Fellow <[email protected]>
With the exception of "file drop" on link shares all other shares need the read permissions at least. Signed-off-by: fenn-cs <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
…le29 [stable29] fix(s3): Don't wait indefinitely for S3 to return
Signed-off-by: Sanskar Soni <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
…le29 [stable29] fix(files_versions): renaming file version when its not a string
Signed-off-by: skjnldsv <[email protected]>
nextcloud#43939 moved the CalDAV/CardDAV redirect checks from the frontend to a new backend API. Since the backend does not send an authentication header, checking for the expected response code 207 of the DAV endpoint does not work anymore, hence the URL of the last redirect is checked instead. This URL is expected to contain a trailing slash, which was not required before, since the DAV endpoint works properly without it (when authenticated). While a trailing slash in the redirect does no harm, it causes many setups to throw an admin panel warning, while in fact the redirects work properly. Furthermore, the proposed "/.well-known/carddav" => "/remote.php/dav/" redirect leads to double slashes, when doing a request to "/.well-known/carddav/", which seems more wrong then right. This change makes the trailing slash optional, hence old and adjusted setups won't throw the warning anymore, and the DAV endpoint works well in both cases. Signed-off-by: MichaIng <[email protected]>
…le29 [stable29] fix(SharingDetailsView): Prevent illegal unselection of read permissions
…le29 [stable29] fix(settings): make trailing slash for caldav/carddav redirects optional
Signed-off-by: Nextcloud bot <[email protected]>
Signed-off-by: Kai Henseler <[email protected]>
Signed-off-by: Kai Henseler <[email protected]>
Was stable29 near tag v29.0.1
Signed-off-by: Kai Henseler <[email protected]>
Signed-off-by: Kai Henseler <[email protected]>
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
printminion-co
requested review from
Altahrim,
ArtificialOwl,
CarlSchwan,
ChristophWurst,
Pytal,
artonge,
come-nc,
icewind1991,
mgallien,
miaulalala,
nfebe,
nickvergessen,
provokateurin,
skjnldsv,
st3iny,
susnux,
szaimen and
tcitworld
as code owners
This comment was marked as spam.
This comment was marked as spam.
Member
|
Sorry fr the automated message @printminion-co 🙈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist