Avoid duplicate files with the same name

[gvmura]

When it renames the temporary file, it tests if the file is already present. If so, it moves to trash the previous version to avoid duplicate files with the same name (message log: "Ignoring duplicate file name: ... on Google Drive for Google user: ...")

[mention-bot]

@gvmura, thanks for your PR! By analyzing the history of the files in this pull request, we identified @MTGap, @AdamWill, @icewind1991 and @Xenopathic to be potential reviewers.

[gvmura]

It doesn't handle duplicate files in Google Drive, it tries to avoid them.
You'll watch #4279 issue.

[icewind1991]

Looks fine as far as I can tell

[rullzer]

Makes sense

[rullzer]

@gvmura thanks a lot for your pull request!
We require all commits to be signed. Could you do this?

Just run:

git commit --amend -s
git push -f

[gvmura]

UPDATE: I have just tried to sign and commit

@rullzer sorry,
I can't sign the fix. If you want, you could sign it with your name.

This morning I tested owncloud 9.1.5 and I saw that when the system create the secondary file it handle the Google version. No "temporary" file is created in Google.
So my fix isn't necessary. Watch owncloud/core#23517

[codecov]

Codecov Report

Merging #4361 into stable11 will increase coverage by <.01%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             stable11    #4361      +/-   ##
==============================================
+ Coverage       57.39%   57.39%   +<.01%     
  Complexity      19439    19439              
==============================================
  Files            1214     1214              
  Lines           72565    72563       -2     
  Branches         1237     1237              
==============================================
  Hits            41650    41650              
+ Misses          30915    30913       -2

Impacted Files	Coverage Δ	Complexity Δ
lib/private/Security/CertificateManager.php	92.78% <0%> (-1.04%)	38% <0%> (ø)
apps/comments/lib/EventHandler.php	100% <0%> (ø)	7% <0%> (ø)	⬇️
lib/private/Server.php	92.74% <0%> (+0.16%)	119% <0%> (ø)	⬇️
lib/private/Files/Storage/DAV.php	7.32% <0%> (+0.23%)	159% <0%> (ø)	⬇️
lib/private/Files/Cache/Propagator.php	96.2% <0%> (+1.26%)	16% <0%> (ø)	⬇️

[rullzer]

@gvmura so this is not needed? Because then we can close this...

[MorrisJobke]

Before merging this keep in mind: this is against stable11

[gvmura]

@rullzer,
it is not needed in owncloud 9.1.5, but nextcloud 11.0.2 uses temporary file and without the fix the problem of duplicate files is present.
I'm going to use nextcloud 12 next month. I have just tested few minutes ago nextcloud 12.0.0.14
[git show: Merge: 810fb7f ec07791]
and the problem is still present.

[MorrisJobke]

@rullzer,
it is not needed in owncloud 9.1.5, but nextcloud 11.0.2 uses temporary file and without the fix the problem of duplicate files is present.
I'm going to use nextcloud 12 next month. I have just tested few minutes ago nextcloud 12.0.0.14
[git show: Merge: 810fb7f ec07791]
and the problem is still present.

Best would be then to have this PR against master and we will take care of backporting to stable11. Could open this PR against master instead?

[gvmura]

@MorrisJobke Best would be then to have this PR against master and we will take care of backporting to stable11. Could open this PR against master instead?

Ok, tomorrow mornign I'll do it.