Use Dependency Injection in register_commands.php

[come-nc]

Summary

Use DI for all commands from Core to stop relying on deprecated methods.

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[come-nc]

There is a service named IntegrityCodeChecker which is not a class name and must be used for integrity commands to not mess up with installation.
It’s at

server/lib/private/Server.php

Line 979 in e224432

$this->registerService('IntegrityCodeChecker', function (ContainerInterface $c) {

Maybe it can be renamed to the class name so that DI can be used?

[come-nc]

Maybe it can be renamed to the class name so that DI can be used?

I pushed that solution, I think it should be fine.

[ChristophWurst]

🧹😎