Skip to content

Conversation

@nextcloud-command
Copy link
Contributor

Auto-generated fix of npm audit

@nextcloud-command nextcloud-command force-pushed the automated/noid/stable24-fix-npm-audit branch from eb06ac6 to cab3566 Compare January 21, 2024 03:12
@blizzz blizzz requested review from a team, nfebe, sorbaugh and szaimen and removed request for a team January 24, 2024 09:30
@blizzz
Copy link
Member

blizzz commented Jan 24, 2024

Perhaps unrelated, but /drone/src/tests/acceptance/features/app-files-sharing-link.feature:170 failed:

  Scenario: sharee can not reshare by link if resharing is disabled in the settings after the share is created # /drone/src/tests/acceptance/features/app-files-sharing-link.feature:170
    Given I act as John                                                                                        # ActorContext::iActAs()
    And I am logged in as the admin                                                                            # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I act as Jane                                                                                          # ActorContext::iActAs()
    And I am logged in                                                                                         # LoginPageContext::iAmLoggedIn()
    And I act as John                                                                                          # ActorContext::iActAs()
    And I rename "welcome.txt" to "farewell.txt"                                                               # FileListContext::iRenameTo()
    And I see that the file list contains a file named "farewell.txt"                                          # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    And I share "farewell.txt" with "user0"                                                                    # FilesAppSharingContext::iShareWith()
    And I see that the file is shared with "user0"                                                             # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
    And I visit the settings page                                                                              # SettingsMenuContext::iVisitTheSettingsPage()
    And I open the "Sharing" section of the "Administration" group                                             # AppNavigationContext::iOpenTheSectionOf()
    And I disable resharing                                                                                    # SettingsContext::iDisableResharing()
    And I see that resharing is disabled                                                                       # SettingsContext::iSeeThatResharingIsDisabled()
      Failed asserting that true is false.
    When I act as Jane                                                                                         # ActorContext::iActAs()
    And I open the Files app                                                                                   # FilesAppContext::iOpenTheFilesApp()
    Then I see that the file list contains a file named "farewell.txt"                                         # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    And I open the details view for "farewell.txt"                                                             # FileListContext::iOpenTheDetailsViewFor()
    And I see that the details view is open                                                                    # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
    And I open the "Sharing" tab in the details view                                                           # FilesAppContext::iOpenTheTabInTheDetailsView()
    And I see that the "Sharing" tab in the details view is eventually loaded                                  # FilesAppContext::iSeeThatTheTabInTheDetailsViewIsEventuallyLoaded()
    And I see that the file is shared with me by "admin"                                                       # FilesAppSharingContext::iSeeThatTheFileIsSharedWithMeBy()
    And I see that resharing the file by link is not available                                                 # FilesAppSharingContext::iSeeThatResharingTheFileByLinkIsNotAvailable()

Restarted the drone run for good measure.

@szaimen
Copy link
Contributor

szaimen commented Jan 24, 2024

See #43080

@szaimen szaimen closed this Jan 24, 2024
@szaimen szaimen deleted the automated/noid/stable24-fix-npm-audit branch January 24, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants