Skip to content

Conversation

@artonge
Copy link
Contributor

@artonge artonge commented Jan 10, 2024

When a user tries to download a shared file that do not have the download permissions, this plugin will throw an error, but the message is misleading.

Here it is adjusted.

@artonge artonge added enhancement 3. to review Waiting for reviews feature: files php Pull requests that update Php code labels Jan 10, 2024
@artonge artonge added this to the Nextcloud 29 milestone Jan 10, 2024
@artonge artonge self-assigned this Jan 10, 2024
@artonge artonge marked this pull request as ready for review January 10, 2024 13:08
@artonge artonge requested review from a team and blizzz and removed request for a team January 10, 2024 14:09
Signed-off-by: Louis Chemineau <[email protected]>
@artonge artonge force-pushed the artonge/fix/view_only_error_message branch from 136539c to 25274f9 Compare January 10, 2024 16:04
@artonge artonge enabled auto-merge January 10, 2024 16:16
@artonge artonge merged commit 14180c5 into master Jan 11, 2024
@artonge artonge deleted the artonge/fix/view_only_error_message branch January 11, 2024 11:12
@ArtificialOwl
Copy link
Member

I have been here

@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement feature: files php Pull requests that update Php code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants