enh(OCP\Translation): Add ITranslationProviderWithId #42649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigcat88
approved these changes
Jan 9, 2024
andrey18106
approved these changes
Jan 9, 2024
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
marcelklehr
force-pushed
the
enh/machine-translation-provider-with-id
branch
from
296cb5d to
c148f84
Compare
Member
Author
|
Drone failure seems unrelated |
…tionProvider Signed-off-by: Marcel Klehr <[email protected]>
nickvergessen
approved these changes
Jan 10, 2024
Member
Author
|
Added ITranslationProviderWithUserId |
Signed-off-by: Marcel Klehr <[email protected]>
marcelklehr
force-pushed
the
enh/machine-translation-provider-with-id
branch
from
e9b4df6 to
1db8888
Compare
nickvergessen
approved these changes
Jan 10, 2024
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
Member
|
Can someone use super power to force merge this? |
Member
|
Thank you, Julius. |
4 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In order to allow External Apps to register machine translation providers, we need to allow declaring a getId() method which is used instead of the class name, as app_api will use an anonymous class to register these and all providers would have the same class name.
Checklist