Skip to content

Conversation

@JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter
Copy link
Contributor Author

/compile amend /

@susnux
Copy link
Contributor

susnux commented Dec 27, 2023

@JuliaKirschenheuter you need to update the snapshots when updating nextcloud-vue.
Should work with npm run test -- --updateSnapshot or something like this

@JuliaKirschenheuter
Copy link
Contributor Author

Thank you @susnux!

Unfortunately i've got 50 failed tests ;( what should i do to fix it?

@skjnldsv
Copy link
Member

/compile

Signed-off-by: julia.kirschenheuter <[email protected]>
@ShGKme ShGKme force-pushed the bump-nc-vue-to-8.4.0 branch from 4fc9729 to 6dc5ae3 Compare January 2, 2024 09:53
@ShGKme
Copy link
Contributor

ShGKme commented Jan 2, 2024

To update snapshots:

npm run test:coverage -- -u
# same as
npm run test:coverage -- --updateSnapshot

-- here is used to pass options/arguments not to npm run command, but to the command it runs (jest --coverage).

Or fast version to skip coverage - directly run Jest:

npx jest -u

Unfortunately i've got 50 failed tests ;( what should i do to fix it?

It happens when there are additional apps in app directory, e.g. activity, photos, text, viewer. Jest doesn't respect .gitignore and runs tests and __mocks__ from extra apps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants