-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
fix(papercut) - rerendered submenu actions for time sensitive actions #41670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
will compile assets once reviews look good! |
apps/files_reminders/src/actions/setReminderSuggestionActions.ts
Outdated
Show resolved
Hide resolved
97ffc66 to
488ded0
Compare
468c71b to
048e8e2
Compare
susnux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is 3rdparty changed?
Pytal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Just gotta remove 3rdparty changes 🙈
048e8e2 to
1be3445
Compare
|
/compile amend/ |
fixed 3rdparty folder - checked out the correct branch for 3rdparty submodule
fcbbd30 to
379c58a
Compare
|
/compile amend / |
379c58a to
f313d3f
Compare
f313d3f to
e1788f2
Compare
|
Let's squash these commits into one @emoral435 :) |
e1788f2 to
b7a00d8
Compare
skjnldsv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also remove the last .filter(Boolean) as FileAction[] then :)
b7a00d8 to
6b95c6d
Compare
|
/compile amend / |
a485b3a to
c31352d
Compare
Signed-off-by: Eduardo Morales <[email protected]>
c31352d to
c4f6803
Compare
|
/compile / |
Signed-off-by: nextcloud-command <[email protected]>
|
/backport to stable28 |
enabled#41336Summary
Changes submenu loading to re-render the actions in the submenu, as the items could potentially be time dependent. As of now, the items within the submenu are only loaded when dependencies change, or upon initial loading of the page, but by loading it whenever the user clicked the button, they wont have to reload the page, saving them an extra click ✅
BEFORE
AFTER
TODO
Checklist