chore(settings): Cleanup IManager and Manager type annotations #41662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
requested review from
ChristophWurst,
blizzz,
julien-nc,
marcelklehr and
nickvergessen
provokateurin
commented
Nov 22, 2023
provokateurin
force-pushed
the
chore/settings/cleanup-manager-type-annotations
branch
from
9a849e1 to
9444333
Compare
ChristophWurst
approved these changes
Nov 22, 2023
nickvergessen
approved these changes
Nov 22, 2023
Member
Author
|
Ugh looking at the implementations more closely I found some more wrong types in the interface :/ |
provokateurin
force-pushed
the
chore/settings/cleanup-manager-type-annotations
branch
from
af0d627 to
b3b86a5
Compare
nickvergessen
approved these changes
Nov 23, 2023
Signed-off-by: jld3103 <[email protected]>
provokateurin
force-pushed
the
chore/settings/cleanup-manager-type-annotations
branch
from
c12a122 to
ae36008
Compare
provokateurin
deleted the
chore/settings/cleanup-manager-type-annotations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use correct types everywhere in IManager and Manager of Settings.
Checklist