Skip to content

Replace input form with NcTextField #41638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Pytal merged 1 commit into from
Nov 22, 2023
Merged

Replace input form with NcTextField #41638

Pytal merged 1 commit into from
Nov 22, 2023

Conversation

@JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter commented Nov 21, 2023

Summary

Before:

image

After:

Peek 2023-11-21 14-39

Checklist

@JuliaKirschenheuter JuliaKirschenheuter added the 3. to review Waiting for reviews label Nov 21, 2023
@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Nov 21, 2023
@solracsf solracsf added this to the Nextcloud 28 milestone Nov 21, 2023
@blizzz blizzz mentioned this pull request Nov 22, 2023
Merged
5 tasks
susnux
susnux reviewed Nov 22, 2023
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good but will have to test it

@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/41625-Replace_contacts-menu_search_and_unified-search_with_NcTextField branch from 70e9e29 to b8f5a8e Compare November 22, 2023 10:44
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/41625-Replace_contacts-menu_search_and_unified-search_with_NcTextField branch 2 times, most recently from 622d20f to c20c3ce Compare November 22, 2023 10:53
@JuliaKirschenheuter JuliaKirschenheuter marked this pull request as ready for review November 22, 2023 10:53
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/41625-Replace_contacts-menu_search_and_unified-search_with_NcTextField branch from c20c3ce to bf4eb2a Compare November 22, 2023 12:16
@JuliaKirschenheuter
Replace input form with NcTextField
ab84540 
Signed-off-by: julia.kirschenheuter <[email protected]>
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/41625-Replace_contacts-menu_search_and_unified-search_with_NcTextField branch from bf4eb2a to ab84540 Compare November 22, 2023 13:15
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 22, 2023
@Pytal Pytal merged commit ca91eda into master Nov 22, 2023
@Pytal Pytal deleted the fix/41625-Replace_contacts-menu_search_and_unified-search_with_NcTextField branch November 22, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pytal Pytal Pytal approved these changes

@ShGKme ShGKme ShGKme approved these changes

@susnux susnux Awaiting requested review from susnux

@szaimen szaimen Awaiting requested review from szaimen

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Milestone

Nextcloud 28

Development

Successfully merging this pull request may close these issues.

[BITV]: Replace contacts-menu search and unified-search with NcTextField

6 participants

@JuliaKirschenheuter @susnux @Pytal @ShGKme @solracsf