Skip to content

fix: Use shortestName instead of sequenceName for Postgres seqence migration #36791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jbmolle wants to merge 2 commits into from
Closed

fix: Use shortestName instead of sequenceName for Postgres seqence migration #36791

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e94d4e
fix: Use shortestName instead of sequenceName because default schema …
jbmolle Feb 21, 2023
97340f9
lint: Follow lint guidelines
jbmolle Feb 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions lib/private/DB/PgSqlTools.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,13 +61,15 @@ public function resynchronizeDatabaseSequences(Connection $conn) {
});

foreach ($conn->getSchemaManager()->listSequences() as $sequence) {
$sequenceName = $sequence->getName();
$namespaceName = $sequence->getNamespaceName();
$shortestName = $sequence->getShortestName($namespaceName);
$sqlInfo = 'SELECT table_schema, table_name, column_name
FROM information_schema.columns
WHERE column_default = ? AND table_catalog = ?';
WHERE column_default = ? AND table_catalog = ? AND table_schema = ?';
$result = $conn->executeQuery($sqlInfo, [
"nextval('$sequenceName'::regclass)",
$databaseName
"nextval('$shortestName'::regclass)",
$databaseName,
$namespaceName
]);
$sequenceInfo = $result->fetchAssociative();
$result->free();
Expand All @@ -76,7 +78,7 @@ public function resynchronizeDatabaseSequences(Connection $conn) {
/** @var string $columnName */
$columnName = $sequenceInfo['column_name'];
$sqlMaxId = "SELECT MAX($columnName) FROM $tableName";
$sqlSetval = "SELECT setval('$sequenceName', ($sqlMaxId))";
$sqlSetval = "SELECT setval('$shortestName', ($sqlMaxId))";
$conn->executeQuery($sqlSetval);
}
}
Expand Down