Remove old sccsphp dependency

[CarlSchwan]

Todos

• Merge Remove old scssphp dependency 3rdparty#1040
• Rebase

[nickvergessen]

Pr is merged, now rebase here?

[CarlSchwan]

this breaks the dyslexia font, I'm working on a fix

I'm now prefixing the custom CSS manually now.

[skjnldsv]

server/apps/theming/lib/Controller/ThemingController.php

Lines 333 to 335 in eb45a6c

	$compiler = new Compiler();
	$compiledCss = $compiler->compileString("body[data-theme-$themeId] { $variables $customCss }");
	$css = $compiledCss->getCss();;

[CarlSchwan]

server/apps/theming/lib/Controller/ThemingController.php

Lines 333 to 335 in eb45a6c

	$compiler = new Compiler();
	$compiledCss = $compiler->compileString("body[data-theme-$themeId] { $variables $customCss }");
	$css = $compiledCss->getCss();;

See this PR this removes the usage of it and do the simple CSS prefixing directly.

[skjnldsv]

See this PR this removes the usage of it and do the simple CSS prefixing directly.

I tested the perf of the scsscacher and it seemed more than ok.
I think this is much more complex and difficult to read. Also it now means themes can inject code that doesn't impact their theme only. I prefer a safe scope :)

[CarlSchwan]

See this PR this removes the usage of it and do the simple CSS prefixing directly.

I tested the perf of the scsscacher and it seemed more than ok. I think this is much more complex and difficult to read. Also it now means themes can inject code that doesn't impact their theme only. I prefer a safe scope :)

This is a 15 lines patch that would allow us to remove 19 000 lines of code. I still think it is worth it, even if the performance reasons are really minor. This is less work in the long term for handling the dependency bump (we are currently minor 2 versions in master and 6 in stable22) and limit a bit more the risk of supply chain attacks.

I'm actually even surprised that @font-face works currently since @font-face can't be nested inside a CSS query and it seems that scssphp will unnest it differently from that node-sass will do. And I don't like depending on nonstandard behavior.

[skjnldsv]

And I don't like depending on nonstandard behavior.

With scss it's proper.

This is a 15 lines patch that would allow us to remove 19 000 lines of code

This is very different since we're talking about a dependency :)
I'm talking about our code maintainability. I don't think the approach this PR do is acceptable 🤷