fix shared mount roots not being returned from getSharesInFolder
#31610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
come-nc
reviewed
Mar 17, 2022
come-nc
approved these changes
Mar 17, 2022
szaimen
requested review from
a team and
skjnldsv
and removed request for
a team
Contributor
|
/backport to stable23 |
Contributor
|
/backport to stable22 |
Merged
Merged
Signed-off-by: Robin Appelman <[email protected]>
icewind1991
force-pushed
the
shares-in-folder-mounts
branch
from
b140451 to
e83ad8c
Compare
Merged
Member
4 tasks
PVince81
approved these changes
Apr 11, 2022
Member
PVince81
left a comment
PVince81
left a comment
There was a problem hiding this comment.
👍
I'm just a bit worried of side effects
Member
|
hmm, besides https://github.com/nextcloud/server/blob/master/apps/dav/lib/Connector/Sabre/SharesPlugin.php#L146 and #31728 I didn't find any other usage for this, so should be fine. |
This was referenced Apr 11, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mountpoints currently aren't shown due to the
f.parentfilter