Skip to content

Fix unresponsive click on avatar in Profile Preview Card #29345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pytal merged 1 commit into from
Oct 21, 2021
Merged

Fix unresponsive click on avatar in Profile Preview Card #29345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions apps/settings/js/vue-settings-personal-info.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion apps/settings/js/vue-settings-personal-info.js.map
View file
Open in desktop

Large diffs are not rendered by default.

64 changes: 27 additions & 37 deletions apps/settings/src/components/PersonalInfo/ProfileSection/ProfilePreviewCard.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@
:show-user-status="true"
:show-user-status-compact="false"
:disable-menu="true"
:disable-tooltip="true"
@click.native.prevent.stop="openStatusModal" />
:disable-tooltip="true" />
<div class="preview-card__header">
<span>{{ displayName }}</span>
</div>
Expand All @@ -57,11 +56,11 @@ export default {
},

props: {
organisation: {
displayName: {
type: String,
required: true,
},
displayName: {
organisation: {
type: String,
required: true,
},
Expand All @@ -75,11 +74,6 @@ export default {
},
},

data() {
return {
}
},

computed: {
disabled() {
return !this.profileEnabled
Expand All @@ -95,9 +89,6 @@ export default {
return null
},
},

methods: {
},
}
</script>

Expand Down Expand Up @@ -142,50 +133,49 @@ export default {
}
}

&__header {
position: relative !important;
width: auto !important;
height: 70px !important;
border-radius: var(--border-radius-large) var(--border-radius-large) 0 0 !important;
&__header,
&__footer {
position: relative;
width: auto;

span {
position: absolute;
bottom: 0;
left: 78px;
overflow: hidden;
text-overflow: ellipsis;
word-break: break-all;

@supports (-webkit-line-clamp: 2) {
display: -webkit-box;
-webkit-line-clamp: 2;
-webkit-box-orient: vertical;
}
}
}

&__header {
height: 70px;
border-radius: var(--border-radius-large) var(--border-radius-large) 0 0;

span {
bottom: 0;
color: var(--color-primary-text);
font-size: 18px;
font-weight: bold;
margin-bottom: 8px;
margin: 0 4px 8px 0;
}
}

&__footer {
position: relative;
width: auto;
height: 46px;

span {
position: absolute;
top: 0;
left: 78px;
color: var(--color-text-maxcontrast);
font-size: 14px;
font-weight: normal;
margin-top: 4px;
margin: 4px 4px 0 0;
line-height: 1.3;

overflow: hidden;
white-space: nowrap;
text-overflow: ellipsis;

@supports (-webkit-line-clamp: 2) {
overflow: hidden;
white-space: initial;
text-overflow: ellipsis;
display: -webkit-box;
-webkit-line-clamp: 2;
-webkit-box-orient: vertical;
}
}
}
}
Expand Down