Hack to prevent warning for read-only wrapper in public links #2122
+11
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @schiessle, @rullzer and @icewind1991 to be potential reviewers. |
Member
|
Please fix it in one way only, either the upstream way or our way: |
Member
|
didn't you add a check in the register method to check for |
Member
Author
I fixed it in the one hacky way to align with upstream ;) |
Member
|
👍 fine by me
Will rebase |
Storage wrappers should normally always be registered inside a presetup hook. However in the public link scenario this is not possible and there is currently no good alternative with the current architecture. Instead of logging a warning every time, this fix prevents the warning to be shown but also adds a FIXME in the code for the future. This is ok because this app is already using private/internal APIs at the moment and should be reworked properly in the future.
Signed-off-by: Morris Jobke <[email protected]>
nickvergessen
force-pushed
the
downstream-26520
branch
from
e07f723 to
b373f52
Compare
Member
Author
|
@LukasReschke @nickvergessen @rullzer Should we backport this to stable10? @enoch85 requested it |
Member
|
fine by me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested this and it works 👍
cc @rullzer @icewind1991 @nickvergessen