[downstream] LDAP empty hardening #1729
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Schiwon <[email protected]>
Signed-off-by: Arthur Schiwon <[email protected]>
|
@blizzz, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nickvergessen, @scrutinizer-auto-fixer and @PVince81 to be potential reviewers. |
Signed-off-by: Arthur Schiwon <[email protected]>
Current coverage is 57.33% (diff: 53.44%)@@ master #1729 diff @@
==========================================
Files 1064 1075 +11
Lines 60424 61413 +989
Methods 6821 6886 +65
Messages 0 0
Branches 0 0
==========================================
+ Hits 34265 35213 +948
- Misses 26159 26200 +41
Partials 0 0
|
Signed-off-by: Arthur Schiwon <[email protected]>
blizzz
force-pushed
the
downstream-ldap-3
branch
from
a363abe to
dade28c
Compare
Member
Author
|
Moody codecov… anyway ready to review @nextcloud/ldap @LukasReschke |
Member
|
Tested and still works 👍 |
Member
|
LGTM |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downstream from owncloud/user_ldap#3 with quite some conflict resolutions, let's see how the tests go :)
@nextcloud/ldap